[10.x] Fixes whereDate, whereDay, whereMonth, whereTime, whereYear and whereJsonLength to ignore invalid $operator
#52704
+258
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crynobone
force-pushed
the
where-invalid-operator
branch
from
5a92005
to
f303beb
Compare
… and `whereJsonLength` to ignore invalid `$operator` Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
crynobone
force-pushed
the
where-invalid-operator
branch
from
ea2559e
to
4ff4011
Compare
crynobone
changed the title
whereDate, whereDay, whereMonth, whereTime, whereYear and whereJsonLength to ignore invalid $operatorwhereDate, whereDay, whereMonth, whereTime, whereYear and whereJsonLength to ignore invalid $operator
| @@ -33,13 +36,16 @@ public function getSQLDeclaration(array $column, AbstractPlatform $platform): st | |||
| MySQLPlatform::class, | |||
| MySQL57Platform::class, | |||
| MySQL80Platform::class, | |||
| MySQL84Platform::class, | |||
There was a problem hiding this comment.
Shouldn't we move these changes to a separate PR?
There was a problem hiding this comment.
10.x is currently on security only updates.
|
Mind if I ask why? Or what is this trying to solve? Isn't it better to throw an I mean, if a particular DBMS supports an operator not listed as valid within the class, I guess the developer would be surprised by this behavior. |
I assume the issue is SQL injection, where the operator comes from user input? We have a similar fallback system for when an invalid sort direction is passed to order by, for example. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.