Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proof of concept: Android: Add voice typing text replacement settings #11058

Conversation

personalizedrefrigerator
Copy link
Collaborator

@personalizedrefrigerator personalizedrefrigerator commented Sep 16, 2024

Summary

This pull request demonstrates one possible way to improve the voice typing feature on Android — by adding a "replacements" setting.

This pull request is intended for discussion and to propose a possible feature. Do not merge this pull request as-is.

Screen recording

out.mp4

The above screen recording shows:

  • A new "Options" button added to the voice typing dialog.
  • The options dialog: Allows specifying:
    1. Words that will be replaced with other words or phrases.
    2. Words that will be removed and cause the next word to start with an uppercase letter.
    3. Whether replacements are enabled or disabled.

Why is this pull request a draft?

  • Code style/structure issues:
    • Uses inline callbacks in places that useCallback should be used.
    • Uses inline styles in places that a useStyle hook should be used.
    • Repeats string values that should be constants (e.g. insert: and uppercase).
  • UI issues:
    • Currently, voice typing continues while its settings dialog is open.
    • It may make sense to also allow opening the settings dialog from Joplin's configuration screen.
    • The size/spacing of elements may need to be adjusted.
    • ...
  • No automated tests.

@personalizedrefrigerator personalizedrefrigerator changed the title Proof of concept: Mobile: Add voice typing replacements settings Proof of concept: Android: Add voice typing replacements settings Sep 16, 2024
@personalizedrefrigerator personalizedrefrigerator changed the title Proof of concept: Android: Add voice typing replacements settings Proof of concept: Android: Add voice typing text replacement settings Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant