Undefined dependancy on Braintree extension

[andrewkett]

Preconditions

• Laybuy_LaybuyPayments 1.1.0
• Magento 2.2.4
• PHP 7.1.10
• Nginx

We were still getting product out of stock errors on returning from Laybuy with products that only had 1 item left in stock. The stock was somehow being decremented to 0 before the order was placed. This problem was specific to our project, I couldn't replicate it on a clean Magento 2.24 build. After comparing differences between our project and clean Magento I eventually figured out that we have both Braintree and Paypal modules disabled as we aren't using them. The Laybuy extension makes use of code from the Braintree module so I enabled Braintree, and then Paypal as it is a dependancy of Braintree. I am still not sure the exact reason why but this has resolved our stock issues.

I have created a pull request defining braintree as a dependancy. This should help anyone else in similar circumstances find the cause of the problem sooner.

Although I think ideally the extension doesn't really need to rely on Braintree does it?

[16hands]

Hi Andrew,

Thanks for the issue report,

We have been refactoring for the Laybuy AUTH changes and will look at this so we can push them in one release