Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MDX] Migration to gatsby-plugin-mdx v4 with fix for onCreatePage trigger issue #4583

Closed
wants to merge 4 commits into from
Closed

[MDX] Migration to gatsby-plugin-mdx v4 with fix for onCreatePage trigger issue #4583

wants to merge 4 commits into from

Conversation

randychilau
Copy link
Contributor

Description

This PR is an updated version of PR #4532 that fixes an issue with the gatsby-plugin-mdx v4 usage of createPage

Notes for Reviewers

Local production and development builds for PR #4532 seemed to be working correctly. However, when there are changes that involve Gatsby's page creation APIs in gatsby-node.js, another set of testing needs to be done with the env variable CI === "true". This can be done with the following command CI=true npm run build". Along with the use of logging tools, it is possible to test how pages will be created for the GitHub Pages server.

Signed commits

  • Yes, I signed my commits.

@randychilau
fix: handle CI=true case with gatsby-plugin-mdx v4
626acef 
Signed-off-by: Randy Lau <randychilau@gmail.com>
@l5io
Copy link
Contributor

l5io commented Jul 19, 2023

🚀 Preview for commit 626acef at: https://64b86cf8fac8c80bb2ab3fb5--layer5.netlify.app

@randychilau randychilau changed the title [MDX] Migration to gatsby-plugin-mdx v4 with CI=true fix for GitHub Pages [MDX] Migration to gatsby-plugin-mdx v4 with fix for .html.html issue Jul 19, 2023
@randychilau randychilau deleted the mdx2-upgrade-v2 branch July 19, 2023 23:56
@randychilau randychilau restored the mdx2-upgrade-v2 branch July 19, 2023 23:58
@randychilau randychilau changed the title [MDX] Migration to gatsby-plugin-mdx v4 with fix for .html.html issue [MDX] Migration to gatsby-plugin-mdx v4 with fix for onCreatePage trigger issue Jul 20, 2023
@randychilau randychilau reopened this Jul 20, 2023
@github-actions github-actions bot added project/meshery area/news A noteworthy article, event, happening area/blog New posts or new blog functionality area/projects An issue relating to Layer5 initiatives (projects) area/community area/learn Related to /learn section area/events area/careers area/resources project/kanvas labels Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/blog New posts or new blog functionality area/careers area/community area/events area/learn Related to /learn section area/news A noteworthy article, event, happening area/projects An issue relating to Layer5 initiatives (projects) area/resources area/site-config project/kanvas project/meshery
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@randychilau @l5io