Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bracket left open in the settings menu code on 0.12.0 rc7 #220

Closed
ghost opened this issue Jun 9, 2017 · 1 comment
Closed

Bracket left open in the settings menu code on 0.12.0 rc7 #220

ghost opened this issue Jun 9, 2017 · 1 comment

Comments

@ghost
Copy link

ghost commented Jun 9, 2017

The Issue

Someone left a bracket open in the settings menu code on 0.12.0 rc7
It shows in the interface just above the 'SHARE DIAGNOSTIC DATA' box

Steps to reproduce

  1. Open LBRY app (Has been seen in Windows and Linux app)
  2. Click the settings cog icon top right of app
  3. Scroll to bottom of screen, bracket */] should be visable top left of the words 'Share Diagnostic Data'

Expected behaviour

Shouldn't be visible

Actual behaviour

Is visible

System Configuration
@kauffj
Copy link
Member

kauffj commented Jun 9, 2017

fixed in #6bfce16

@kauffj kauffj closed this as completed Jun 9, 2017
@tzarebczan tzarebczan mentioned this issue Jun 11, 2017
Closed
jessopb pushed a commit that referenced this issue Jan 22, 2022
@rafael-xmr @jessopb
Stickers/emojis fall out / improvements (#220)
1dd3149 
* Fix error logs

* Improve LBC sticker flow/clarity

* Show inline error if custom sticker amount below min

* Sort emojis alphabetically

* Improve loading of Images

* Improve quality and display of emojis and fix CSS

* Display both USD and LBC prices

* Default to LBC tip if creator can't receive USD

* Don't clear text-field after sticker is sent

* Refactor notification component

* Handle notifications

* Don't show profile pic on sticker livestream comments

* Change Sticker icon

* Fix wording and number rounding

* Fix blurring emojis

* Disable non functional emote buttons
jessopb added a commit that referenced this issue Jan 24, 2022
@jessopb @rafael-xmr @tzarebczan
Bringing in emotes, stickers, and refactors from ody (#7435)
0b41fc0 
* [New Feature] Comment Emotes (#125)

* Refactor form-field

* Create new Emote Menu

* Add Emotes

* Add Emote Selector and Emote Comment creation ability

* Fix and Split CSS

* [New Feature] Stickers (#131)

* Refactor filePrice

* Refactor Wallet Tip Components

* Add backend sticker support for comments

* Add stickers

* Refactor commentCreate

* Add Sticker Selector and sticker comment creation

* Add stickers display to comments and hyperchats

* Fix wrong checks for total Super Chats

* Stickers/emojis fall out / improvements (#220)

* Fix error logs

* Improve LBC sticker flow/clarity

* Show inline error if custom sticker amount below min

* Sort emojis alphabetically

* Improve loading of Images

* Improve quality and display of emojis and fix CSS

* Display both USD and LBC prices

* Default to LBC tip if creator can't receive USD

* Don't clear text-field after sticker is sent

* Refactor notification component

* Handle notifications

* Don't show profile pic on sticker livestream comments

* Change Sticker icon

* Fix wording and number rounding

* Fix blurring emojis

* Disable non functional emote buttons

* new Stickers! (#248)

* Add new stickers (#347)

* Fix cancel sending sticker (#447)

* Refactor scrollbar CSS for portal components outside of main

Refactor channelMention suggestions into new textareaSuggestions component

Install @mui/material packages

Move channel mentioning to use @mui/Autocomplete combobox without search functionality

Add support for suggesting Emotes while typing ':'

Improve label to display matching term

Add back and improved support for searching while mentioning

Add support for suggesting emojis

Fix non concatenated strings

Add key to groups and options

Fix dispatch props

Fix Popper positioning to be consistent

Fix and Improve searching

Add back support for Winning Uri

Filter default emojis with the same name as emotes

Remove unused topSuggestion component

Fix text color on darkmode

Fix livestream updating state from both websocket and reducer and causing double of the same comments to appear

Fix blur and focus commentCreate events

Fix no name after @ error

* desktop tweaks

Co-authored-by: saltrafael <76502841+saltrafael@users.noreply.github.com>
Co-authored-by: Thomas Zarebczan <tzarebczan@users.noreply.github.com>
Co-authored-by: Rafael <rafael.saes@odysee.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kauffj