Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The URL name is automatically suggested. #375

Closed
wants to merge 1 commit into from
Closed

The URL name is automatically suggested. #375

wants to merge 1 commit into from

Conversation

hackrush01
Copy link
Contributor

Fixes #347

@hackrush01 hackrush01 requested a review from kauffj July 22, 2017 09:20
@hackrush01
Copy link
Contributor Author

I found use of var in L106, L107 and L206 also, should that be changed to let/const also?

@kauffj
Copy link
Member

kauffj commented Jul 24, 2017

Merged. Yes, @hackrush01, you can replace var with const or let as appropriate. The app was started prior to using ES2016, so I'm sure there are plenty of var remaining. However, it's not safe to just do a find and replace, since I believe let/const use block level scoping, while var is function level. I doubt we're relying on function level variable scoping, but I still wouldn't global find/replace without inspection, just in case.

@kauffj kauffj closed this Jul 25, 2017
@hackrush01 hackrush01 deleted the auto_suggest_URL branch July 29, 2017 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kauffj kauffj Awaiting requested review from kauffj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hackrush01 @kauffj