Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sending a confirmation email for requested evaluations to teachers optional #74

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

irinahpe
Copy link
Contributor

@irinahpe irinahpe commented Sep 12, 2023

Evasys-managers can now choose wether to have an email sent to teachers of the course of which they started an evaluation on

Copy link
Contributor

@Laur0r Laur0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks! Only two small things, it would be good to have an additional help button explaining under what circumstances emails are sent to teachers (only when the evaluation is requested from the overview page). Second, for existing categories the checkbox is set to false not true, maybe you can have another look at that.

@irinahpe
Copy link
Contributor Author

I added the help button and changed the default values also in the db-tables. But since the default values are saved as the persistent properties mode_flags in the evasys_category and the evasys_category is only created after the category has been added to evasys in the admin settings, it is not possible to change the dafault values afterwards.

Base automatically changed from feature/automatic-eval-request to master June 7, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants