-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/completiontracking #299
Conversation
…n status after db queries
4d90aa8
to
48e2bf4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something does not work as intended with the vote completion. As soon as the rating period starts, this is set to true for all users without having submitted a rating.
lib.php
Outdated
@@ -70,6 +70,10 @@ function ratingallocate_supports($feature) { | |||
return true; | |||
case FEATURE_COMPLETION_TRACKS_VIEWS: | |||
return true; | |||
case FEATURE_COMPLETION_HAS_RULES: | |||
return true; | |||
case FEATURE_COMPLETION_HAS_RULES: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think one of these duplicates can be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thanks!
Adds custom completion rules to the ratingallocate activity.
Options are completion on having voted and completion on having been allocated.