Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: new forecast of the workflowoverview destroys specificdatelogic #169

Open
FelixDiLenarda opened this issue Jan 10, 2023 · 0 comments
Open

Comments

@FelixDiLenarda
Copy link
Contributor

I noticed the new forecast of how many course will be triggered (workflowoverview).

I really like the idea of the new workflowoverview but there is a buggy implication.

Specificdatetrigger determines if it is already used by the 'timelastrun' setting.

Since the get_count_of_courses_to_trigger_for_workflow Function calls get_course_recordset_where() of the trigger,
'timelastrun' is set at now.

Therefore after the trigger showed once in the overview how many courses will be triggered, it will not trigger again today.
(assumed we want to set the specific date as Today).

This could also influence other triggers which should only run once in a day.

In my opinion either the logic of the workflowoverview needs to be changed or we need to change 'specificdatetrigger'.

What do you think?

Greetings
Felix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant