Fix workflowoverview for big instances #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I thought I update the pipeline I hope this was okay :) |
justusdieckmann
force-pushed
the
MBS-7377-Fix_workflowoverview_for_big_instances
branch
from
126af9e
to
abfb770
Compare
justusdieckmann
requested changes
May 19, 2023
There was a problem hiding this comment.
Hey @PhMemmel,
thanks for your contribution!
I only found a small bug. Once that's fixed, I'll gladly merge this :)
Cheers
Justus
|
Requested changes done, I also rebased onto current master. Of course feel free to squash the fix commit. Thank you for the review! |
PhMemmel
force-pushed
the
MBS-7377-Fix_workflowoverview_for_big_instances
branch
from
abfb770
to
ab2138c
Compare
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #170
I decided to make this feature an admin setting. So if an admin experiences performance issues he can deactive the config setting and still will have the opportunity to configure workflows.
This also can be seen as workaround for #169, not a real fix for this issue though :-)