-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log step currently processed #164
base: master
Are you sure you want to change the base?
Conversation
Hey @jojoob to be honest I think is is quiet a lot of logging - I could image logging number of courses processed by a step does that work for you? |
Or have I missed something? |
AH we had the same problem, which version of the plugin are you using? |
We are using v3.11-r2 on Moodle 3.9. The error page did not show anything when we had this specific problem. PS: Sorry for the late reply. |
I am also sorry for the late reply! what kind of problem did you have? I think this is something which should be covered by it! |
The course deletion (even when done manually) resulted in an error caused by a 3rd party activity module. Most likely the plugin instance in that course throw an exception within its I can't tell you exact details anymore since we uninstalled the problematic plugin from our production environment and it now has not enough priority to invest time to reproduce. |
PS: Since the |
do you mean https://github.com/learnweb/moodle-tool_lifecycle/blob/master/classes/processor.php#L125 this is certainly not the case as this is exactly the call which inserts the course in the error table. Or did you mean another statement 🤔 |
Anyway I would prefer to find the reason for not inserting and fix that instead of logging the course, sorry for the inconvenience 😞 |
Extend the workflow log with the sub-plugin name of the step currently being processed and the course ID.
Beyond that, there are probably additional ways to improve logging.