Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show menu entry when a manual or automatic workflow is active #199

Merged
merged 3 commits into from
Mar 14, 2024

Conversation

justusdieckmann
Copy link
Member

No description provided.

@justusdieckmann justusdieckmann changed the title Show menu point when a manual or automatic workflow is active Show menu entry when a manual or automatic workflow is active Feb 27, 2024
@NinaHerrmann
Copy link
Contributor

MAH. I just realized that the plugin has as a default two workflows -

Exclude delayed courses trigger
Exclude site course trigger

@justusdieckmann can you include a check for that?

@NinaHerrmann
Copy link
Contributor

sorry i did not really think about it

@justusdieckmann
Copy link
Member Author

MAH! Could have definitiv thought about that myself, will do! :)

@NinaHerrmann
Copy link
Contributor

Nearly forgot about that one... Looks good thank you so much! 🥰

@NinaHerrmann NinaHerrmann merged commit 33cbd05 into master Mar 14, 2024
46 checks passed
@justusdieckmann justusdieckmann deleted the show-menu-point-on-workflow-active branch April 24, 2024 09:33
NinaHerrmann added a commit that referenced this pull request Jun 19, 2024
* Removed ,

* CI: Update for Moodle 4.2

* Workflow backup: Do not save attributes when they are null

* Bump version

* MBS-7377: Fix workflowoverview for big instances

* Fix wrong calculation of courses counts in template context

* fix upload workflow (#185)

* fix upload workflow

* inserting feedback

* finally

* Add check if process exists. (#191)

This prevents courses to be processed which had been rescued by the teacher.

* Update README.md

Make Subplugin List (and link to wiki) more apparent

* Improve help text for integration of icons (manual trigger) (#193)

* Improved help text for the integration of icons

* Improved help text for the integration of icons

* Update for Moodle 4.3 (#190)

* CI: Update for Moodle 4.3

* Prevent dynamic property access on classes for PHP 8.2

* phpcbf for styles etc.

---------

Co-authored-by: Justus Dieckmann <justusdieckmann@wwu.de>
Co-authored-by: NinaHerrmann <nina.herrmann@uni-muenster.de>

* Hide menu when there is no manual workflow (#195)

Co-authored-by: Justus Dieckmann <justusdieckmann@wwu.de>

* Fix step and trigger reordering: only change the relevant workflow (#200)

* Reorder the remaining active workflows when disabling a workflow (#201)

This fixes #128.

* Show menu entry when a manual or automatic workflow is active (#199)

* Show menu point when a manual or automatic workflow is active

* Rename reset cache function

* Show menu entry if there are workflows other than the default two

---------

Co-authored-by: Justus Dieckmann <justusdieckmann@wwu.de>

* Check backup consistency before importing workflow (#196)

* Check backup consistency before importing workflow

* Fix PHPDocs

* Use existing category in backup_and_restore test

* lifecycletrigger_categories: A bit of general refactoring

* lifecycletrigger_categories: Don't fail if category doesn't exist

* Add possibility to force import of errorneous backup

* Use $force = false as default in restore_workflow:execute

* Display only unique errors when Workflows causes multiple errors

---------

Co-authored-by: Justus Dieckmann <justusdieckmann@wwu.de>
Co-authored-by: NinaHerrmann <nina.herrmann@uni-muenster.de>

* CI: Update for Moodle 4.4

* Codestyle PHPCBF

* Sort strings in lang files alphabetically

* Fix sortindex gaps in upgrade step

* Bump version

* The columns in active_manual_workflows_table shouldn't be sortable

* Shell escape the release notes in the release workflow (#207)

Co-authored-by: Justus Dieckmann <justusdieckmann@wwu.de>

* Fix mustache

* added mtrace statement for logging failed mails (#214)

* Shell escape release workflow for realsies this time (#208)

---------

Co-authored-by: Justus Dieckmann <justusdieckmann@wwu.de>
Co-authored-by: Philipp Memmel <philipp.memmel@gmail.com>
Co-authored-by: Justus Dieckmann <45795270+justusdieckmann@users.noreply.github.com>
Co-authored-by: Melanie Treitinger <66598405+melanietreitinger@users.noreply.github.com>
Co-authored-by: KerstinSc <kerstin.schmidt@th-nuernberg.de>
Co-authored-by: Kata <35190838+olivabigyo@users.noreply.github.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants