Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small LineChart improvements: Allow invalid Y values, fix Line.setXXX() #294

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

moritzboth
Copy link

Greetings,

I changed LineChart so you can add Float.NaN Y values for line interruptions (invalid values). So far this works for the regular and square lines only (all I need). Cubic is to be done.

Also, Line.setCubic(false) and Line.setSquare(false) would reset the respective other setting to false which is not expected. Even worse, Line.setSquare(true) would result in a regular line if Line.setCubic(true) was called before and vice versa.

This is my first pull request on github. I wondered if it made sense to separate those two unrelated concerns into two pull requests but could not find an obvious way to do so. In case I did something stupid please bear with me :)

moritz

@moritzboth moritzboth changed the title Small LineChart improvements Small LineChart improvements: Allow invalid Y values, fix Line.setXXX() Jun 8, 2016
@lecho
Copy link
Owner

lecho commented Jun 8, 2016

Hi, thanks, let me look at that:)

@CatalinPrata
Copy link

CatalinPrata commented Aug 29, 2017

Hello @lecho any chances to get this in soon on a new version :) ? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants