fix: broken code signing #208
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this change is needed to build libs / frameworks or e.g. to build app without signing in your case you should set the same property on your app target to YES |
|
As @kambala-decapitator said, the reason for adding this to the toolchain was that it fixes more issues than it creates. If you need code signing, just add it to your own CMakeLists.txt or as an argument |
|
Thanks for the explanation! I think it might be worth mentioning in the release notes (once you release the next version). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've integrated ios-cmake from the latest commit into https://github.com/BabylonJS/BabylonNative Playground app generation and after this commit: b65d894 code signing stoped working on real devices. Unsettling this makes the app work as expected again.
This is the error I was getting: BabylonJS/BabylonNative#1404
I couldn't find any reason this change was introduced (it was just pushed to main) maybe I'm missing something but I think it shouldn't be the default option as it breaks the builds.