Ustream live wip #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasongornall
commented
Apr 4, 2018
| @@ -93,6 +93,16 @@ const TEST_URLS = [ | |||
| url: 'https://www.mixcloud.com/mixcloud/meet-the-curators/', | |||
| switchTo: 'https://www.mixcloud.com/mixcloud/mixcloud-curates-4-mary-anne-hobbs-in-conversation-with-dan-deacon/', | |||
| skip: true | |||
| }, | |||
| { | |||
jasongornall
commented
Apr 4, 2018
| } | ||
| }, | ||
| onEnded: () => done() | ||
| if (test.onSeek) { |
There was a problem hiding this comment.
I guss onSeek isn't seekTo I think it's fine tho
jasongornall
commented
Apr 4, 2018
test/specs/ReactPlayer.js
Outdated
| @@ -154,6 +164,7 @@ describe('ReactPlayer', () => { | |||
| // Use a count object to ensure everything is called at least once | |||
| let count = {} | |||
| const bump = key => { | |||
| console.log(key) | |||
andybarron
suggested changes
Apr 4, 2018
src/Player.js
Outdated
| @@ -75,6 +75,7 @@ export default class Player extends Component { | |||
| const playedSeconds = this.getCurrentTime() || 0 | |||
| const loadedSeconds = this.getSecondsLoaded() | |||
| const duration = this.getDuration() | |||
|
|
|||
There was a problem hiding this comment.
probs should get rid of this so our diffs aren't muddied
src/Player.js
Outdated
| // Only call onProgress if values have changed | ||
| if (progress.played !== this.prevPlayed || progress.loaded !== this.prevLoaded) { | ||
|
|
||
| // Special Case for Live Typed so they still OnProgress |
There was a problem hiding this comment.
What Even Is proper Capitalization ;)
test/specs/ReactPlayer.js
Outdated
| @@ -154,6 +164,7 @@ describe('ReactPlayer', () => { | |||
| // Use a count object to ensure everything is called at least once | |||
| let count = {} | |||
| const bump = key => { | |||
| console.log(key) | |||
src/players/index.js
Outdated
| @@ -7,8 +7,9 @@ import { Wistia } from './Wistia' | |||
| import { Twitch } from './Twitch' | |||
| import { DailyMotion } from './DailyMotion' | |||
| import { Mixcloud } from './Mixcloud' | |||
| import { FilePlayer } from './FilePlayer' | |||
| import { UstreamLive } from './UstreamLive' | |||
|
|
|||
src/players/index.js
Outdated
|
|
||
| import { FilePlayer } from './FilePlayer' | ||
| export default [ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.