Prevent Babel from transpiling node_modules packages #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 🙏 |
albertchae
added a commit
to rubyforgood/freeforest
that referenced
this pull request
Apr 5, 2020
albertchae
added a commit
to rubyforgood/freeforest
that referenced
this pull request
Apr 5, 2020
…er loaders Manually set height of map div to get something visible for now More context: visgl/react-map-gl#874 lewagon/rails-templates#81 mapbox/mapbox-gl-js#3422
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add a configuration line in
config/webpack/environment.jsto removenode_modulesfolder from being processed by loaders (includingbabel)Was causing an issue with
Mapboxjs library.Read more here:
Webpacker doc: https://github.com/rails/webpacker/blob/master/docs/v4-upgrade.md#excluding-node_modules-from-being-transpiled-by-babel-loader
Mapbox library issue: mapbox/mapbox-gl-js#3422