Angular bracket imports for reusable reactor modules #2404
Conversation
| @@ -99,6 +99,7 @@ public Boolean caseModel(Model object) { | |||
| public Boolean caseImport(Import object) { | |||
| return new ComparisonMachine<>(object, Import.class) | |||
| .equalAsObjects(Import::getImportURI) | |||
| .equalAsObjects(Import::getImportPackage) | |||
There was a problem hiding this comment.
Does this effectively function like "equal to importURI OR equal to importPackage"?
lhstrh
changed the title
| timeout: 2 sec | ||
| } | ||
|
|
||
| import Count from <lib/Count.lf> |
There was a problem hiding this comment.
@tanneberger, tagging you because it still appears to be unclear what should be inside the angular brackets. I thought the notation was reserved for packages, not local paths?
There was a problem hiding this comment.
This is the old version. I still need to implement what we discussed last time. My focus here was to fix the formatting errors causing the check to fail. I'm currently working on a new version where we shorten the paths inside the angular brackets to <root/file.lf> for downloaded Lingo packages and lib/file.lf for locally defined libraries
There was a problem hiding this comment.
Do you mean "lib/file.lf" for locally defined libraries? My assumption had been that angular brackets are only for published packages, not locally defined ones.
There was a problem hiding this comment.
Exactly, use angular brackets for published packages and quotation marks for locally defined libraries. In my previous comment, I was referring to "lib/file.lf", but I mistakenly omitted the quotation marks
…d test case for federated LF program using new imports
…inal; Refined importPackage management across affected files
…s in federated LF programs
This PR proposes a new import statement syntax to distinguish between user-defined reactors import and reusable reactors imports. The new syntax for importing reusable reactors will use angular brackets, as shown:
import Reactor from <path/to/lib/Reusables.lf>.