Cleanup #127
Merged
Cleanup #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The issue that is causing the TypeScript tests to fail right now looks like it could be the same issue that I referenced previously in this comment. |
Yes, it sure looks like it. I think this is a shortcoming, not an intended feature of TS. Or is it? |
|
Yes, based on the linked issue it looks like we are not the only ones who experience this as a shortcoming. |
|
Looks like this passes. OK to merge, @petervdonovan? |
petervdonovan
approved these changes
Jan 21, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.d.tsfiles and get types from npm insteadlib/core/index.d.tsso that types are included in the npm mpdule (also see https://cameronnokes.com/blog/the-30-second-guide-to-publishing-a-typescript-package-to-npm/)