PWX-35567: Add Spec handling for volume flag checksummed #2395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnbu-jenkins
force-pushed
the
xattr-checksum
branch
from
f81aa26
to
0ed4d9b
Compare
sulakshm
reviewed
Jan 9, 2024
api/spec/spec_handler.go
Outdated
| @@ -147,6 +147,7 @@ var ( | |||
| mountOptionsRegex = regexp.MustCompile(api.SpecMountOptions + `=([A-Za-z0-9:;@=#]+),?`) | |||
| sharedv4MountOptionsRegex = regexp.MustCompile(api.SpecSharedv4MountOptions + `=([A-Za-z0-9:;@=#]+),?`) | |||
| cowOnDemandRegex = regexp.MustCompile(api.SpecCowOnDemand + "=([A-Za-z]+),?") | |||
| checksumDataRegex = regexp.MustCompile(api.SpecChecksumData + "=([A-Za-z]+),?") | |||
There was a problem hiding this comment.
is this regex correct?
Can you not give checksum_data=0|1?
parsebool will allow it.
There was a problem hiding this comment.
Yes, parsebool allows it, fixed it.
cnbu-jenkins
force-pushed
the
xattr-checksum
branch
from
0ed4d9b
to
2e8c875
Compare
vivekpx
changed the title
cnbu-jenkins
force-pushed
the
xattr-checksum
branch
from
2e8c875
to
8126844
Compare
Signed-off-by: Vivek Patidar <[email protected]>
cnbu-jenkins
force-pushed
the
xattr-checksum
branch
from
8126844
to
529b31c
Compare
vivekpx
changed the title
|
This PR is stale because it has been in review for 3 days with no activity. |
ggriffiths
reviewed
Jan 30, 2024
vivekpx
requested review from
sulakshm and
nikhil-bhupale
and removed request for
sulakshm and
adikulkarni0
|
This PR is stale because it has been open for 180 days with no activity. Update this PR or it will be automatically closed in 6 months. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add Spec handling for volume flag checksummed
Which issue(s) this PR fixes (optional)
Closes # PWX-35567
Testing Notes
Special notes for your reviewer: