Using short hostname instead of FQDN hostnames to avoid custom DNS. #2404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is stale because it has been in review for 3 days with no activity. |
|
This PR is stale because it has been open for 180 days with no activity. Update this PR or it will be automatically closed in 6 months. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-Off-By: Diptiranjan
What this PR does / why we need it:
Some clusters may be configured with different DNS.
It is better to give short hostnames than adding
cluster.localas default for px service endpoint.Which issue(s) this PR fixes (optional)
Closes #
or
PWX-35059
Testing Notes
Creating clusterpair with the above changes vendored in stork.
➜ stork git: ✗ storkctl get clusterpair -n kube-system
NAME STORAGE-STATUS SCHEDULER-STATUS CREATED
cp3 Ready Ready 23 Jan 24 08:55 UTC
Special notes for your reviewer:
Add any notes for the reviewer here.