Skip to content
This repository has been archived by the owner on Sep 6, 2022. It is now read-only.

remove deprecated Bytes method from the Key interface #204

Merged
merged 1 commit into from
Jul 22, 2021

Conversation

marten-seemann
Copy link
Contributor

This method has been deprecated since May 2019.

@marten-seemann marten-seemann force-pushed the remove-bytes-from-key-interface branch from 7b11ee6 to 36adc8d Compare July 22, 2021 19:02
@Stebalien Stebalien merged commit d28ef63 into master Jul 22, 2021
@Stebalien Stebalien deleted the remove-bytes-from-key-interface branch July 22, 2021 19:18
@Stebalien
Copy link
Member

@marten-seemann it looks like the deprecation here wasn't quite "correct". Unfortunately, we have quite a few packages that still use it.

I'm fixing them, but we might want to consider reverting before releasing (for now).

@marten-seemann
Copy link
Contributor Author

@marten-seemann it looks like the deprecation here wasn't quite "correct". Unfortunately, we have quite a few packages that still use it.

Doesn't that just mean that we were negligent fixing our own code? Why would we revert this, if we can just fix it (replacing key.Bytes() by crypto.Marshal{Private,Public}Key(key) is not that hard (just tedious).

@Stebalien
Copy link
Member

Doesn't that just mean that we were negligent fixing our own code?

We signaled deprecation with "DEPRECATED" instead of "Deprecated: " so go vet didn't catch it.

@aschmahmann aschmahmann mentioned this pull request Aug 23, 2021
62 tasks
lukasz-zimnoch added a commit to keep-network/keep-core that referenced this pull request Sep 28, 2021
The aforementioned method was deprecated and
removed in `v0.9.0` of `go-libp2p-core`.
The recommended replacement is using the
`crypto.MarshalPublicKey` function. See:
libp2p/go-libp2p-core#204
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants