Skip to content
This repository has been archived by the owner on Sep 6, 2022. It is now read-only.

Remove btcsuite/btcd dep #272

Merged
merged 1 commit into from
Jul 5, 2022
Merged

Remove btcsuite/btcd dep #272

merged 1 commit into from
Jul 5, 2022

Conversation

MarcoPolo
Copy link
Contributor

@MarcoPolo MarcoPolo commented Jul 5, 2022

I don't think need to pull in this btcd dependency. btcec is now it's own module.

This will also prevent us from forcing the btcd dep upgrade on downstream users. It breaks somethings especially https://github.com/whyrusleeping/ledger-filecoin-go which is used by lotus.

@marten-seemann
Copy link
Contributor

Will we run into the problem fixed in #254 again?

My conclusion back then was that this will have to wait until we stop using Go 1.17.

@MarcoPolo
Copy link
Contributor Author

go checks pass, so maybe not?

I think removing this dep would side step that problem by not having btcd to conflict with.

@MarcoPolo
Copy link
Contributor Author

Was able to sucessfully remove this dep from go-libp2p as well which unblocked lotus from being able to update: filecoin-project/lotus#8970

@marten-seemann
Copy link
Contributor

go checks pass, so maybe not?

The checks passed in this repo, but not when updating go-libp2p to the new version. I'm ok with merging this (actually, I'd be very happy to get rid of this hack!!), but we should make sure that go-libp2p will still pass CI when we make this change.
More details in #252.

@MarcoPolo
Copy link
Contributor Author

The checks passed in this repo, but not when updating go-libp2p to the new version.

Seems like the tests are passing in go-libp2p too: libp2p/go-libp2p#1641

Copy link
Contributor

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then let’s get rid of this hack!

@MarcoPolo MarcoPolo merged commit 8814b31 into master Jul 5, 2022
@MarcoPolo MarcoPolo deleted the marco-remove-btcd-dep branch July 5, 2022 23:49
marten-seemann added a commit that referenced this pull request Jul 9, 2022
@ajnavarro ajnavarro mentioned this pull request Aug 24, 2022
72 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants