Skip to content
This repository has been archived by the owner on Sep 6, 2022. It is now read-only.

Conversation

aarshkshah1992
Copy link
Contributor

@aarshkshah1992 aarshkshah1992 commented Oct 1, 2019

For libp2p/go-libp2p-peerstore#93
Looks like only Remove Public Key is required.

Copy link
Member

@raulk raulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break consumers of this interface, as no implementations offer this method (I think). What's the motivation and context here?

@aarshkshah1992
Copy link
Contributor Author

aarshkshah1992 commented Oct 1, 2019

@raulk Apologies. Have linked the issue in the description now. This is to enable us to remove the public key from the peerstore when a peer disconnects so as to not cause memory leaks.

Implementation is at libp2p/go-libp2p-peerstore#94

@raulk
Copy link
Member

raulk commented Jan 13, 2022

Functionality landed in libp2p/go-libp2p-peerstore#184.

@raulk raulk closed this Jan 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants