fix: try to re-add existing peers when the routing table is empty #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, we could decide to _not_ add a peer, disconnect from most peers, and be unable to query the DHT even if we're technically connected to a peer in the DHT.
raulk
approved these changes
Dec 11, 2019
| } | ||
|
|
||
| // we should now _re-add_ some peers to the routing table | ||
| for i := 0; i < 100; i++ { |
There was a problem hiding this comment.
Timing conditions in tests make me sad :-( But we don't have a better way right now.
There was a problem hiding this comment.
Not yet, unfortunately.
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, we could decide to not add a peer, disconnect from most peers, and
be unable to query the DHT even if we're technically connected to a peer in the
DHT.
This is a small subset of active bootstrapping.