This repository has been archived by the owner on May 26, 2022. It is now read-only.
stop using goprocess for shutdown #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
force-pushed
the
remove-goprocess
branch
from
7d05040
to
f1b7a19
Compare
Yeah, we've been bitten by silent bugs here in the past. Testing end-to-end is tricky, but it should be possible to test parts of this library, at least. |
marten-seemann
force-pushed
the
remove-goprocess
branch
from
f1b7a19
to
2c47a1d
Compare
Stebalien
approved these changes
Sep 19, 2021
| nat.mappings[m] = struct{}{} | ||
| nat.refCount.Add(1) | ||
| nat.mappingmu.Unlock() | ||
| go nat.refreshMappings(m) |
There was a problem hiding this comment.
If it's not too difficult, it would be nice to have a single worker loop to handle refreshing mappings.
There was a problem hiding this comment.
Yes, in a follow-up PR.
There was a problem hiding this comment.
Unfortunately, it's not that easy, because of the way that mapping and nat are coupled. Not sure I want to make such a change in a repo where we don't have any tests...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I really wish the original author of this library had written tests. Making a change like this without any tests feels extremely brittle.