Skip to content
This repository has been archived by the owner on Aug 19, 2022. It is now read-only.

remove metadata interning #185

Merged
merged 1 commit into from
Dec 2, 2021
Merged

remove metadata interning #185

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 3 additions & 13 deletions pstoremem/metadata.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,18 +9,15 @@ import (

type memoryPeerMetadata struct {
// store other data, like versions
// ds ds.ThreadSafeDatastore
ds map[peer.ID]map[string]interface{}
dslock sync.RWMutex
interned map[string]interface{}
ds map[peer.ID]map[string]interface{}
dslock sync.RWMutex
}

var _ pstore.PeerMetadata = (*memoryPeerMetadata)(nil)

func NewPeerMetadata() *memoryPeerMetadata {
return &memoryPeerMetadata{
ds: make(map[peer.ID]map[string]interface{}),
interned: make(map[string]interface{}),
ds: make(map[peer.ID]map[string]interface{}),
}
}

Expand All @@ -30,13 +27,6 @@ func (ps *memoryPeerMetadata) Put(p peer.ID, key string, val interface{}) error
}
ps.dslock.Lock()
defer ps.dslock.Unlock()
if vals, ok := val.(string); ok && (key == "AgentVersion" || key == "ProtocolVersion") {
if interned, ok := ps.interned[vals]; ok {
val = interned
} else {
ps.interned[vals] = val
}
}
m, ok := ps.ds[p]
if !ok {
m = make(map[string]interface{})
Expand Down