Skip to content
This repository has been archived by the owner on May 26, 2022. It is now read-only.

Commit

Permalink
use defers to close files
Browse files Browse the repository at this point in the history
  • Loading branch information
marten-seemann committed Feb 12, 2021
1 parent eb76fca commit fe226b7
Showing 1 changed file with 4 additions and 10 deletions.
14 changes: 4 additions & 10 deletions tracer.go
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,8 @@ func newQlogger(qlogDir string, role logging.Perspective, connID []byte) io.Writ
}

func (l *qlogger) Close() error {
defer os.Remove(l.f.Name())
defer l.f.Close()
if err := l.Writer.Flush(); err != nil {
return err
}
Expand All @@ -78,6 +80,7 @@ func (l *qlogger) Close() error {
if err != nil {
return err
}
defer f.Close()
buf := bufio.NewWriter(f)
c, err := zstd.NewWriter(buf, zstd.WithEncoderLevel(zstd.SpeedFastest))
if err != nil {
Expand All @@ -89,14 +92,5 @@ func (l *qlogger) Close() error {
if err := c.Close(); err != nil {
return err
}
if err := buf.Flush(); err != nil {
return err
}
if err := l.f.Close(); err != nil {
return err
}
if err := os.Remove(l.f.Name()); err != nil {
return err
}
return f.Close()
return buf.Flush()
}

0 comments on commit fe226b7

Please sign in to comment.