Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix error handling in Parallel.search #48

Merged
merged 1 commit into from
May 19, 2021
Merged

fix error handling in Parallel.search #48

merged 1 commit into from
May 19, 2021

Conversation

marten-seemann
Copy link
Contributor

Found by staticcheck.

I'm not sure I understand the original code, it doesn't seem correct to continue if err != nil.

@marten-seemann marten-seemann mentioned this pull request May 19, 2021
Merged
Stebalien
Stebalien approved these changes May 19, 2021
View reviewed changes
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the goal here was to return an error if all of them failed? But yeah, we should definitely continue.

@marten-seemann marten-seemann merged commit 118e5e2 into master May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stebalien Stebalien Stebalien approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marten-seemann @Stebalien