Skip to content
This repository has been archived by the owner on May 26, 2022. It is now read-only.

Add multiplex transport #16

Closed
wants to merge 1 commit into from
Closed

Add multiplex transport #16

wants to merge 1 commit into from

Conversation

victorb
Copy link
Member

@victorb victorb commented Jan 24, 2017

No description provided.

@Stebalien
Copy link
Member

Currently, we do this at the application level (and call the transport mplex, that is, /mplex/6.7.0). @whyrusleeping do we want to do this here instead?

@Stebalien
Copy link
Member

Note: Travis is breaking because multiplex needs to be imported as a gx dep.

@Kubuxu
Copy link
Member

Kubuxu commented Aug 31, 2017

I would go onto something else, can we remove those transports form here and have the app add them? This way the app has freedom to choose and we might reduce our dependency tree.

As we are planning transport plugins, it might be wise to make them top level injected.
Only other packages depending on muxers are (looking at yamux, the oldest one):

  1. go-libp2p-swarm - which is using them in the same exact manner as this package
  2. go-peerstream
  3. go-stream-muxer - for tests, probably can be swapped out for some dummy muxer

@whyrusleeping
Copy link
Contributor

Closing this, we're moving away from embedding any multiplexers here.

@raulk raulk deleted the add-multiplex branch May 15, 2020 13:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants