Skip to content
This repository has been archived by the owner on May 26, 2022. It is now read-only.

fix: avoid returning typed nils #257

Merged
merged 1 commit into from
Apr 22, 2021
Merged

fix: avoid returning typed nils #257

merged 1 commit into from
Apr 22, 2021

Conversation

Stebalien
Copy link
Member

No description provided.

marten-seemann
marten-seemann approved these changes Apr 20, 2021
View reviewed changes
Copy link
Contributor

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't hurt, but I don't think there's a rule that says "If err != nil, the other return values must be nil / their default value". I had assumed the convention is that if err != nil, you can't make any assumption about the other return values.

@Stebalien Stebalien merged commit a73c29a into master Apr 22, 2021
@Stebalien
Copy link
Member Author

Yeah, it's just confusing to have typed nils.

@Stebalien Stebalien deleted the fix/typed-nil branch April 22, 2021 07:39
@Stebalien Stebalien mentioned this pull request May 11, 2021
Closed
27 tasks
@aschmahmann aschmahmann mentioned this pull request May 14, 2021
Closed
71 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marten-seemann marten-seemann marten-seemann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Stebalien @marten-seemann