Skip to content
This repository has been archived by the owner on May 26, 2022. It is now read-only.

remove redundant self-dialing check, simplify starting of dialWorkerLoop #273

Merged
merged 3 commits into from
Sep 7, 2021

Conversation

marten-seemann
Copy link
Contributor

We already check for self dials in

if p == s.local {
return nil, ErrDialToSelf
}
. We don't need to check again before starting the dialWorkerLoop. This allows us to get rid of the error return value.

Also, API-wise, it's always nice when the caller starts the go routine.

@marten-seemann marten-seemann merged commit 93f7ca9 into master Sep 7, 2021
@marten-seemann marten-seemann deleted the clean-up-self-dial branch September 7, 2021 12:43
@aschmahmann aschmahmann mentioned this pull request Dec 1, 2021
80 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants