This repository has been archived by the owner on Sep 10, 2022. It is now read-only.
call the connection gater when accepting connections and after crypto handshake #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 7, 2020
aarshkshah1992
changed the title
8 tasks
raulk
suggested changes
May 13, 2020
raulk
changed the title
|
@raulk I couldn't figure out how to add tests for this in this repo back then so I implemented all these tests in the |
|
@aarshkshah1992 I removed ginkgo in #60. |
|
This needs a release in go-libp2p-core to we can import a proper version. Other than that, it's good to go now. |
raulk
approved these changes
May 15, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For libp2p/go-libp2p#872.
Core PR at libp2p/go-libp2p-core#139.
We apply gating to accepted(inbound connections from a socket before we begin upgrading them) AND secured(the security protocol has been negotiated) connections in the upgrader.
However, please note that we don't apply gating to upgraded connections here as we want to send a Disconnect message with an appropriate reason for them. Hence, the best place to do it is the Swarm.