Skip to content

Commit

Permalink
websocket: don't return transport.ErrListenerClosed on closing listener
Browse files Browse the repository at this point in the history
  • Loading branch information
sukunrt committed Jul 8, 2024
1 parent 2212800 commit 8a71985
Showing 1 changed file with 13 additions and 10 deletions.
23 changes: 13 additions & 10 deletions p2p/transport/websocket/listener.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,11 @@ package websocket

import (
"crypto/tls"
"errors"
"fmt"
"net"
"net/http"
"strings"
"sync"

"github.com/libp2p/go-libp2p/core/transport"

Expand All @@ -22,8 +23,11 @@ type listener struct {

laddr ma.Multiaddr

closed chan struct{}
incoming chan *Conn

closeOnce sync.Once
closeErr error
closed chan struct{}
}

func (pwma *parsedWebsocketMultiaddr) toMultiaddr() ma.Multiaddr {
Expand Down Expand Up @@ -122,7 +126,6 @@ func (l *listener) Accept() (manet.Conn, error) {
c.Close()
return nil, err
}

return mnc, nil
case <-l.closed:
return nil, transport.ErrListenerClosed
Expand All @@ -134,13 +137,13 @@ func (l *listener) Addr() net.Addr {
}

func (l *listener) Close() error {
l.server.Close()
err := l.nl.Close()
<-l.closed
if strings.Contains(err.Error(), "use of closed network connection") {
return transport.ErrListenerClosed
}
return err
l.closeOnce.Do(func() {
err1 := l.nl.Close()
err2 := l.server.Close()
<-l.closed
l.closeErr = errors.Join(err1, err2)
})
return l.closeErr
}

func (l *listener) Multiaddr() ma.Multiaddr {
Expand Down

0 comments on commit 8a71985

Please sign in to comment.