failed to start relay finder: relayFinder already running

[Shawn-Huang-Tron]

I start a node in my local mac, and sometimes this error will show up:
2023-01-04T11:42:33.113+0800 ERROR autorelay autorelay/autorelay.go:80 failed to start relay finder {"error": "relayFinder already running"}

It sounds like that most time it appeared after my mac running a whole night , or I close my mac.

I have seen your code, is it because that when network changed, libp2p try to start relayFinder again?
Should this error be ignored?

go-libp2p v0.24.2

[MarcoPolo]

we probably check if is already running and not try to start it again. Want to take a stab at fixing it?

[Shawn-Huang-Tron]

Hope to fix it . Thank you. Cause this error won't have any effect to functionity but people will get confused.

[marten-seemann]

I think @sukunrt already has a fix for this.

[sukunrt]

this will be fixed by #2185 and #2225

however those are PRs for separate issues so a separate PR for this should be fine.
the approach I used is here:

go-libp2p/p2p/host/autorelay/autorelay.go

Lines 87 to 95 in b78104d

	err := r.relayFinder.Start()
	if errors.Is(err, errAlreadyRunning) {
	log.Debug("tried to start already running relay finder")
	} else if err != nil {
	log.Errorw("failed to start relay finder", "error", err)
	} else {
	r.metricsTracer.RelayFinderStatus(true)
	}
	case network.ReachabilityPublic:

[marten-seemann]

@sukunrt Is this fixed now?

[sukunrt]

yeah this should be fixed now