autorelay: add metrics #2185
Merged
autorelay: add metrics #2185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@marten-seemann For RelayReservation Requests I'm not tracking the error reason currently. that would require |
sukunrt
force-pushed
the
autorelay-metrics
branch
3 times, most recently
from
3e3bccd
to
bb3a62c
Compare
sukunrt
force-pushed
the
autorelay-metrics
branch
from
a7ead08
to
ae1330e
Compare
sukunrt
commented
Mar 21, 2023
sukunrt
force-pushed
the
autorelay-metrics
branch
2 times, most recently
from
f2d358e
to
5c8dce8
Compare
metrics added: relay finder status reservation request outcomes current reservations candidate circuit v2 support current candidates relay addresses updated num relay address scheduled work times
sukunrt
force-pushed
the
autorelay-metrics
branch
from
5c8dce8
to
4fce126
Compare
sukunrt
force-pushed
the
autorelay-metrics
branch
from
99249d0
to
bd3f1f6
Compare
marten-seemann
approved these changes
Apr 5, 2023
| } | ||
|
|
||
| func (re ReservationError) Error() string { | ||
| return fmt.Sprintf("reservation error: status: %s reason: %s err: %s", pbv2.Status_name[int32(re.Status)], re.Reason, re.err) |
There was a problem hiding this comment.
Any reason to not just use the String method on the status?
Suggested change
| return fmt.Sprintf("reservation error: status: %s reason: %s err: %s", pbv2.Status_name[int32(re.Status)], re.Reason, re.err) | |
| return fmt.Sprintf("reservation error: status: %s reason: %s err: %s", re.Status, re.Reason, re.err) |
| return "success" | ||
| } | ||
|
|
||
| status := "err other" |
There was a problem hiding this comment.
Suggested change
| status := "err other" | |
| status := "other" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
metrics added:
relay finder status
reservation request outcomes
current reservations
candidate circuit v2 support
current candidates
relay addresses updated
num relay address
scheduled work times
closes: #2181