Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

option for custom dns resolver #1073

Merged
merged 3 commits into from
Apr 15, 2021
Merged

option for custom dns resolver #1073

merged 3 commits into from
Apr 15, 2021

Conversation

vyzo
Copy link
Contributor

@vyzo vyzo commented Apr 12, 2021

No description provided.

@vyzo vyzo requested review from lidel and aschmahmann April 12, 2021 09:43
@lidel lidel mentioned this pull request Apr 12, 2021
9 tasks
@vyzo vyzo requested a review from Stebalien April 14, 2021 18:24
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we actually need to use the resolver somewhere?

@vyzo
Copy link
Contributor Author

vyzo commented Apr 14, 2021

the code is already there AFAICT, we just needed to add it to the basic host opts in config. Did I miss that?

NATManager: cfg.NATManager,
EnablePing: !cfg.DisablePing,
UserAgent: cfg.UserAgent,
MultiaddrResolver: cfg.MultiaddrResolver,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Stebalien we use it here

Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we just never wired this up...

@vyzo vyzo merged commit 3ef2f76 into master Apr 15, 2021
@vyzo vyzo deleted the feat/custom-resolver branch April 15, 2021 09:17
@Stebalien Stebalien mentioned this pull request May 11, 2021
27 tasks
@aschmahmann aschmahmann mentioned this pull request May 14, 2021
71 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants