fix: re-expose AutoNAT service on BasicHost #1088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, lotus relies on this and we don't have a good alternative at the moment. 1. The "correct" way to get the status is to subscribe to the "discoverability" events and read the first event (you're guaranteed to see a "current status" event). However, this is a bit annoying. 2. Ideally, you'd call host.Addrs() to get the list of "good" addresses. Unfortunately, we don't feed enough information back into the Host from AutoNAT for this to be truly useful (yet).
marten-seemann
approved these changes
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, lotus relies on this and we don't have a good alternative at the moment.