move go-libp2p-quic-transport here #1424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The certificate doesn’t matter, since it is not validated anywehere (yet), but we need to send something.
The tls.Config was removed from the quic.Config in quic-go/quic-go#713.
Support for stream deadlines was added in quic-go/quic-go#579.
The session context was introduced in quic-go/quic-go#774.
This also requires dropping support for Go 1.8.
read the client option from the simultaneous connect context
Technically, someone can set net.ipv4.ip_nonlocal_bind=1 to bind to non-existent IP addresses, but I'm comfortable making this change and seeing if anyone complains. I highly doubt it'll have any impact. If it doesn't work out, we have other options (e.g., catch the "invalid route" error and try again). fixes #238
reuse the same router until we change listeners
In the swarm, we're calling Close for every connection before it is garbage collected. We therefore don't need to start a Go routine here just to see when a connection is closed. We now also increment the reuse counter every time a connection is dialed. This simplifies closing the connection.
don't start a Go routine for every connection dialed
use the Resource Manager
vyzo
approved these changes
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1187.
Note that this disables the cross-version integration tests living in go-libp2p-quic-transport. They will be replaced with our cross-libp2p-version Testground tests very soon.