move go-libp2p-nat here #1513
Merged
move go-libp2p-nat here #1513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some hardware doesn't support UPnP with durations.
If we use same NAT agent and call for the same permanent mapping again we get the same mapping, no harm done. If router dies, we will remap again. Just pros, no cons.
Otherwise, we'll try to port-map localhost.
only map *usable* addresses
NATs only care about TCP/UDP and ports. Using multiaddrs here made this library really hard to work with correctly. Furthermore, this library doesn't _actually_ support specifying the internal IP address. However, we'd still _act_ like the internal IP address mattered. This caused all sorts of mismatches.
remove all uses of multiaddrs
switch to libp2p's go-nat fork
1. It was unused. 2. It was broken. Attempting to register a notification listener would have registered the notifier itself. 3. We need to switch to some consistent event/notification system anyways so we're going to replace this code no matter what. (found by @pornin)
fix: remove notifier
nit: fix log format
typo and changed deprecated method
remove unused field permanent from mapping
chore: update go-log
stop using goprocess for shutdown
Fix error log
Stebalien
approved these changes
May 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was also not on the list in #1187, but I can't see a reason to not consolidate this repo as well.