change the default key type to Ed25519 #1576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interestingly, this change is driving the AutoRelay |
|
I think this is a change we should have made a while ago, RSA keys are a pita. |
Stebalien
approved these changes
Jun 1, 2022
MarcoPolo
approved these changes
Jun 14, 2022
This was referenced Jun 25, 2022
Closed
Closed
marten-seemann
force-pushed
the
ed25519-default-key-type
branch
from
82a6e1c
to
11b284c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cryptographically, there's no reason to prefer RSA over Ed25519 (quite the contrary, actually!).
The peer ID spec says that all implementations MUST support Ed25519, so this should be a safe change to make.
@vyzo @Stebalien Are you aware of any backwards compatibility issues this might cause (that wouldn't be better handled by the application that requires backwards compatibility)?