ping: fix flaky test #1617
Merged
ping: fix flaky test #1617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoPolo
reviewed
Jun 27, 2022
|
|
||
| err = h1.Connect(ctx, peer.AddrInfo{ | ||
| ID: h2.ID(), | ||
| Addrs: h2.Addrs(), | ||
| Addrs: []ma.Multiaddr{h2.Addrs()[0]}, |
There was a problem hiding this comment.
Is there a change we can do that does this at a higher level? I think we see this flakiness in other tests too.
There was a problem hiding this comment.
True, this is not the first time I'm submitting a patch like this.
At which level would you suggest to do it?
MarcoPolo
approved these changes
Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1616.
If we end up with 2 connections (TCP and QUIC) between the nodes, the dialing node might close one of those connection.
This will cause a stream reset on the connection that the dialed node might have chosen for its ping stream.