rcmgr: Fix threshold calculation #1722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sorry to chime in here, but this PR solves quite some issues in a project of mine that it's based on libp2p. since I've tried to bump to latest I met various problems that I couldn't pin point easily in tests, hence I didn't opened any issue because I was still digging from my side. That being said I've pinned to this PR and (almost) all tests went back to green: Just wanted to let you know, here looks good 👍 , thanks/kudos for fixing it! |
vyzo
approved these changes
Aug 27, 2022
dennis-tra
added a commit
to dennis-tra/nebula
that referenced
this pull request
Oct 16, 2022
fixes resource manager infinite limits libp2p/go-libp2p#1722
juju812
added a commit
to juju812/edgemesh
that referenced
this pull request
Apr 1, 2023
burp go-libp2p to v0.23.0 to fix InfiniteLimits MaxInt64 overflow refer to PR: libp2p/go-libp2p#1722
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1721
This changes the code to check for overflows and handle them.
This also adds a special case to check if the limit is MaxInt64 and return early since we assume this is an infinite limit (just to save a big int multiplication).