noise: implement an API to send and receive early data #1728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
MarcoPolo
approved these changes
Sep 3, 2022
| return err | ||
| } | ||
| } else if len(initialPayload) > 0 { | ||
| return fmt.Errorf("received unexpected early data (%d bytes)", len(initialPayload)) |
There was a problem hiding this comment.
This changes the old behavior which would ignore any initialPayload. I see were adding a test case around this. Is there any worry about backwards incompatibility with this change?
There was a problem hiding this comment.
I don't think anybody has been sending initial data until now, so this is probably fine.
marten-seemann
force-pushed
the
noise-early-data2
branch
from
0a1f02e
to
8be14f4
Compare
This was referenced Sep 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new version of #1645, extending the API introduced in #1663. Closes #1645.
Part of #1717.
This PR is a prerequisite for moving go-libp2p-webtransport into this repo.