Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publicize NAT manager struct #199

Merged
2 commits merged into from
Jun 6, 2017
Merged

Publicize NAT manager struct #199

2 commits merged into from
Jun 6, 2017

Conversation

enzoh
Copy link
Contributor

@enzoh enzoh commented Jun 3, 2017

No description provided.

@ghost
Copy link

ghost commented Jun 3, 2017

Awesome, thanks for taking this on! Could you make NATManager an interface and rename the existing struct to something like NATPortMap? That'll make it easier to have multiple different NAT implementations in the future.

@ghost
Copy link

ghost commented Jun 5, 2017

Thanks, LGTM 👍

@ghost
Copy link

ghost commented Jun 5, 2017

I'll merge and make a release when #189 is merged, should be today

@ghost ghost merged commit 644df8e into libp2p:master Jun 6, 2017
marten-seemann pushed a commit that referenced this pull request Aug 9, 2022
feat: use a clock interface to better support testing for pstoremem
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant