Expose muxer ids #2012
Merged
Expose muxer ids #2012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschmahmann
force-pushed
the
feat/expose-muxer-ids
branch
from
eb2eda8
to
d4c5966
Compare
aschmahmann
commented
Jan 24, 2023
marten-seemann
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The protocol IDs of the stream multiplexers are not exposed as constants, which makes using them a pretty miserable experience since you have to hunt through the code to find them. This is particularly true for mplex which, while still being the only multiplexer used in parts of the libp2p ecosystem, does not have its protocol ID referenced in go-libp2p outside of tests anymore (also the constructor documentation said
mpluxinstead ofmplex).This exposes the protocol IDs with an exported constant
IDas is done for Noise and TLS.Also, fixes a documentation bug indicating that mplex was used by default.
Note: the various ipfs-camp-2019 examples can be updated as well post-release so that the constants are only defined once within go-libp2p.