Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basic_host: Fix flaky tests #2136

Merged
merged 1 commit into from
Feb 24, 2023
Merged

Conversation

MarcoPolo
Copy link
Collaborator

Fixes flaky TestHostProtoPreknowledge test.


h1.Start()
h2.Start()

// Prevent pushing identify information so this test actually _uses_ the super protocol.
h1.RemoveStreamHandler(identify.IDPush)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why after the Start? This will cause an Identify Push to be sent.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Start in identify is what sets the stream handler. Removing the stream handler before start is no-op since it's not even registered.

Identify won't do anything until these nodes are connected.

@MarcoPolo MarcoPolo merged commit 29785d2 into master Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants