correctly handle WebTransport addresses without certhashes #2239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoPolo
commented
Apr 5, 2023
options.go
Outdated
| @@ -262,6 +262,7 @@ func AddrsFactory(factory config.AddrsFactory) Option { | |||
| if cfg.AddrsFactory != nil { | |||
| return fmt.Errorf("cannot specify multiple address factories") | |||
| } | |||
|
|
|||
|
|
||
| // NormalizeMultiaddr returns a multiaddr suitable for equality checks. | ||
| // If the multiaddr is a webtransport component, it removes the certhashes. | ||
| func (h *BasicHost) NormalizeMultiaddr(addr ma.Multiaddr) ma.Multiaddr { |
There was a problem hiding this comment.
I assume this would move into the address pipeline, once we have it, right?
There was a problem hiding this comment.
Sure! Anywhere that isn't adding another method to BasicHost
marten-seemann
approved these changes
Apr 5, 2023
marten-seemann
changed the title
marten-seemann
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2233. Closes #2227. Fixes #2223.