swarm: don't dial unspecified addresses #2560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
approved these changes
Sep 7, 2023
|
Should we have a test case for this? |
sukunrt
force-pushed
the
sukun/unspecified-addr
branch
from
c9d082d
to
2b8f0ce
Compare
|
added a test. |
marten-seemann
approved these changes
Sep 7, 2023
fredcarle
added a commit
to sourcenetwork/defradb
that referenced
this pull request
Nov 11, 2023
Since libp2p/go-libp2p#2560, `0.0.0.0` is no longer valid as a peer connection address. This is causing issues for our tests so we change the IP to `127.0.0.1`.
fredcarle
added a commit
to sourcenetwork/defradb
that referenced
this pull request
Nov 11, 2023
Since libp2p/go-libp2p#2560, `0.0.0.0` is no longer valid as a peer connection address. This is causing issues for our tests so we change the IP to `127.0.0.1`.
4 tasks
fredcarle
added a commit
to sourcenetwork/defradb
that referenced
this pull request
Nov 13, 2023
Since libp2p/go-libp2p#2560, `0.0.0.0` is no longer valid as a peer connection address. This is causing issues for our tests so we change the IP to `127.0.0.1`.
fredcarle
added a commit
to sourcenetwork/defradb
that referenced
this pull request
Nov 13, 2023
## Relevant issue(s) Resolves #2043 ## Description This PR updates go dependencies that couldn't be done by dependabot for different reasons. One of which is the result of deprecating `libpeer.ID.Pretty` from `libp2p`. An [update](libp2p/go-libp2p#2560) to `libp2p` also made it no longer valid to connect to a peer on `0.0.0.0`. We now need to use `127.0.0.1` for our tests.
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
## Relevant issue(s) Resolves sourcenetwork#2043 ## Description This PR updates go dependencies that couldn't be done by dependabot for different reasons. One of which is the result of deprecating `libpeer.ID.Pretty` from `libp2p`. An [update](libp2p/go-libp2p#2560) to `libp2p` also made it no longer valid to connect to a peer on `0.0.0.0`. We now need to use `127.0.0.1` for our tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.