close wait channel in all cases, not just success #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whyrusleeping
force-pushed
the
fix/id-hang
branch
from
3d341c0
to
6dc5e19
Compare
Merged
marten-seemann
added a commit
that referenced
this pull request
Apr 22, 2022
This is now handled by the resource manager.
marten-seemann
pushed a commit
that referenced
this pull request
Aug 9, 2022
disable inline-peer id test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
NewStreamorSelectProtoOrFailreturns an error currently, anyone waiting for that connection would hang forever since the wait channel wouldnt get closed.