Update id.go #51
Closed
Update id.go #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello, i see that protocols are set in the populateMessage() but for the consumeMessage() there is a line comment for it but no code for it not sure if this intentional during dev. thanks
|
@efealatan hrm... I think that was there to remind us that at some point we want to track that information. Maybe instead of removing it we can turn it into a clearer comment saying that? |
|
Cool no worries, added a small todo to the comment to make it clear thanks |
marten-seemann
pushed a commit
that referenced
this pull request
Jan 17, 2022
We're still rate-limited to once every 10 seconds. However, this means that setting the grace period to something below one minute actually _does_ something useful. fixes #51
marten-seemann
pushed a commit
that referenced
this pull request
Apr 21, 2022
clear out extra dial jobs after dial finishes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
i see that protocols are set in the populateMessage() but for the consumeMessage() there is a line comment for it but no code for it not sure if this intentional during dev.
thanks